fix: wallet connect - sake.lido.fi dApp - staking transaction gets stuck #16348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saledjenic
requested review from
alaibe,
alexjba,
virginiabalducci,
anastasiyaig and
a team
and removed request for
a team
saledjenic
commented
Sep 16, 2024
| maxFeePerGas = hexToGwei(tx.maxFeePerGas) | ||
| maxPriorityFeePerGas = hexToGwei(tx.maxPriorityFeePerGas) | ||
|
|
||
| // TODO: check why we need to set gasPrice here and why if it's not checked we cannot send the tx and fees are unknown???? | ||
| gasPrice = hexToGwei(tx.maxFeePerGas) |
There was a problem hiding this comment.
Not sure why gasPrice is used in this context (refer to TODO in the line above)?
saledjenic
commented
Sep 16, 2024
| @@ -36,15 +36,15 @@ template getProp(obj: JsonNode, prop: string, value: var typedesc[uint64]): bool | |||
|
|
|||
| template getProp(obj: JsonNode, prop: string, value: var typedesc[string]): bool = | |||
| var success = false | |||
| if (obj.kind == JObject and obj.contains(prop)): | |||
| if (obj.kind == JObject and obj.contains(prop) and obj[prop].kind == JString): | |||
There was a problem hiding this comment.
All functions in this file should have this check and obj[prop].kind == .... but when I did that I couldn't start the app (got crash) which undoubtedly means that in some places we have incorrect type usage or receiving incorrect json data. That should be fixed in another PR.
Jenkins Builds
|
virginiabalducci
approved these changes
Sep 16, 2024
alaibe
approved these changes
Sep 17, 2024
| @@ -484,13 +484,11 @@ SQUtils.QObject { | |||
|
|
|||
| // Beware, the tx values are standard blockchain hex big number values; the fees values are nim's float64 values, hence the complex conversions | |||
| if (!!tx.maxFeePerGas && !!tx.maxPriorityFeePerGas) { | |||
There was a problem hiding this comment.
as we are ine post eip1559 case, both are present, we do not need to set gas price i believe
There was a problem hiding this comment.
exactly, that was my question about, here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Placed tx:
Fixes #16096